Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getSubfieldValues public. #21

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

rudolfbyker
Copy link
Contributor

It would be very useful for me to be able to access getSubfieldValues from outside the object.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage     84.44%   84.44%           
  Complexity      272      272           
=========================================
  Files            24       24           
  Lines           598      598           
=========================================
  Hits            505      505           
  Misses           93       93           
Impacted Files Coverage Δ Complexity Δ
src/Fields/Field.php 95.08% <100.00%> (ø) 29.00 <4.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac7b94...7ada8ff. Read the comment docs.

@danmichaelo danmichaelo merged commit efecc80 into scriptotek:master Jul 30, 2020
@danmichaelo
Copy link
Member

No prob! Let me know if you need a new release.

@rudolfbyker
Copy link
Contributor Author

Wow, thanks for the quick merge! Regarding the release: Let met develop my project some more. I'll probe you for a release when it's closer to completion. For now, I can get away with using the specific commit in composer.json :)

@rudolfbyker
Copy link
Contributor Author

Regarding the release, I think now would be a good time, if you are willing, to make a new release. I would greatly appreciate it.

@danmichaelo
Copy link
Member

That's really nice of me to promise a release, and then go off the radar for a month 😅 Sorry about that, I realise I actually need to unsubscribe a few things to clean up my GitHub feed to a point where I actually start looking at it again :)

Anyways, 2.2.0, here we go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants