This repository was archived by the owner on Dec 3, 2022. It is now read-only.
Fixed an issue with the extension not working with tabs-indented files, slightly improved style#3
Merged
scriptin merged 1 commit intoscriptin:masterfrom Jan 31, 2015
giovannicalo:master
Merged
Fixed an issue with the extension not working with tabs-indented files, slightly improved style#3scriptin merged 1 commit intoscriptin:masterfrom giovannicalo:master
scriptin merged 1 commit intoscriptin:masterfrom
giovannicalo:master
Conversation
…s, slightly improved style
scriptin
added a commit
that referenced
this pull request
Jan 31, 2015
Fixed an issue with the extension not working with tabs-indented files, slightly improved style
scriptin
added a commit
that referenced
this pull request
Jan 31, 2015
Owner
|
@giovannicalo Thank you so much! |
|
@giovannicalo you rock |
scriptin
added a commit
that referenced
this pull request
Aug 31, 2017
Fixed an issue with the extension not working with tabs-indented files, slightly improved style
scriptin
added a commit
that referenced
this pull request
Aug 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the issue you had with the extension not working with tabs-indented files.
The main problem was the
cm-tabclass being aninline-blockinstead of a regularinline.The second problem was the formula you used to calculate the
padding-left, which wouldn't take character width into account for tab characters.The style change might break something in CodeMirror. However, I noticed no difference.
I also shortened the regular expression that finds the position of the first non-space character and replaced single quotes with double quotes to be consistent with the rest of the file.