Left padding of editor view

[chris-scheurle]

There is a problem with some designs, that specify a padding-left other than 0for #editor-holder .CodeMirror pre.

Could you please check for any existing padding on the element, and add that to the one you apply directly to the element? 😄

[scriptin]

I don't know if there's any way to extract a padding-left value set by a theme. These don't work: window.getComputedStyle(elt).paddingLeft, window.getComputedStyle(elt)["padding-left"], window.getComputedStyle(elt).getPropertyValue("padding-left"). Empty string is returned in all cases. I guess that styles are not applied at the moment I check that, but I can't understand why. I use AppInit.appReady, so everything should be loaded, and it's probably not the case that theme is loading after the extension.

Honestly, I think it's impossible to resolve this issue. Docs on Brackets API are kind of atrocious, I can't even understand the lifecycle of an extension. Not to mention this whole extension is based on a hack...

If someone knows a way around that, please let me know.

[scriptin]

One possible solution would be to use text-indent: ... hanging;, but no.

[chris-scheurle]

As @scriptin said:

These don't work

😢 ... whatever you did in 0.2.6, it worked for me.

Everything looked like it should, everything looked great. 😄 ... and now it's gone, again. 😞

So, please:

• either _re_implement the changes of 0.2.6. Maybe it's not a perfect bugfix, but at least it was a partial one.
  Edit: I just took a look at the other issue referenced above. Ok, I guess it's not an option to do that. 😀
• or: introduce some settings option for brackets.json where I can set a desired "base padding left" (reflecting the values in the design I'm using), manually.

As @scriptin said:

One possible solution would be to use text-indent: ... hanging;, but no.

I don't know anything about coding Brackets plugins and yes, the API docs are kind of ... confusing. But:
considering there is no "everything is loaded, displayed and done" event (or if there are multiple plugins waiting for that one and changing things after the fact): maybe one could use something like setInterval() and watch for changes in one of the properties mentioned by you above (adjusting the padding on change and canceling the interval if nothing has changed for some time)?

[chris-scheurle]

Considering there are a lot of lines to watch and so there woud have to be a lot of intervals to set: maybe one could do something along the lines of my last suggestion using a MutationObserver (on the parent of all the lines, with childList: true, attributes: true, attributeOldValue: true, attributeFilter: ['style']), and another one watching for newly added style and link elements?

[scriptin]

Since I need to get the theme-specific padding-left only when an editor is loaded or when a different theme is selected, setting a timeout may work. I'll try it later, thanks for your suggestions.

[macbookandrew]

So e6e20f6 fixes the issue I saw with Brackets Beta 1.6…it remains to be seen what happens when the stable release comes out.

Edit: to be more specific, it’s adding 4px of padding to every line instead of just empty lines, as the stable version was doing.