Skip to content

Update dependency eslint-plugin-compat to v4.1.0 #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ jobs:
- run:
name: pwa
command: yarn pwa
- run:
name: optisize
command: yarn optisize
- run:
name: prod
command: yarn prod
3 changes: 1 addition & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [18.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -19,5 +19,4 @@ jobs:
- run: yarn
- run: yarn lint
- run: yarn pwa
- run: yarn optisize
- run: yarn prod
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,4 @@ install:
script:
- yarn lint
- yarn pwa
- yarn optisize
- yarn prod
18 changes: 7 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,7 @@ npm run build
npm start --env server
```

6. Images optimization using [Optisize](https://github.com/three11/optisize)

7. SVG Sprite generating using [spritesh](https://www.npmjs.com/package/spritesh)
6. SVG Sprite generating using [spritesh](https://www.npmjs.com/package/spritesh)

All svg files located in `assets/images/svg` are merged into a single `sprite.svg` file in `dist` directory.

Expand All @@ -229,7 +227,7 @@ npm run build
</svg>
```

8. All front-end assets are stored in an auto-generated `dist` folder.
7. All front-end assets are stored in an auto-generated `dist` folder.

## Assets

Expand Down Expand Up @@ -269,7 +267,6 @@ There are several scripts defined in the `package.json` file:
{
"build": "webpack --mode=production",
"start": "webpack --watch --mode=development",
"optisize": "optisize --src=\"./assets/images\"",
"html": "php index.php > index.html",
"critical": "critical index.html > assets/dist/critical.css",
"rm-html": "rm index.html",
Expand All @@ -282,12 +279,11 @@ Here is a bit more about what each script does:

1. `build`: Builds the production version of the javascript and css bundles, regenerates PNG and SVG sprites.
2. `start`: Starts the development sequence, regenerates PNG and SVG sprites, opens your default browser and watches for changes.
3. `optisize`: Optimizes your PNG, JPG and GIF images.
4. `html`: Converts your `index.php` file to `index.html`.
5. `critical`: Using the `index.html` extracts the critical css and generates a `critical.css` file in the `assets/dist` folder which is then inlined in the `index.php` file.
6. `rm-html`: Deletes the `index.html` file.
7. `pwa`: Generates boilerplate files for a PWA. More info [here](https://github.com/scriptex/create-pwa).
8. `prod`: Runs 1, 4, 5, 6. (In this exact order).
3. `html`: Converts your `index.php` file to `index.html`.
4. `critical`: Using the `index.html` extracts the critical css and generates a `critical.css` file in the `assets/dist` folder which is then inlined in the `index.php` file.
5. `rm-html`: Deletes the `index.html` file.
6. `pwa`: Generates boilerplate files for a PWA. More info [here](https://github.com/scriptex/create-pwa).
7. `prod`: Runs 1, 4, 5, 6. (In this exact order).

In order to use the ability to generate critical CSS you must have the `php` binary exposed in your bash terminal.
More about PHP's commandline usage can be found [here](http://php.net/manual/en/features.commandline.php).
Expand Down
10 changes: 7 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "webpack-mpa-ts",
"version": "3.12.0",
"version": "4.0.0",
"description": "Multi page app setup with webpack",
"keywords": [
"MPA",
Expand Down Expand Up @@ -29,7 +29,6 @@
"scripts": {
"build": "webpack --mode=production",
"start": "webpack --watch --mode=development",
"optisize": "optisize --src=\"./assets/images\"",
"html": "php index.php > index.html",
"critical": "node critical.mjs",
"rm-html": "rm index.html",
Expand All @@ -43,7 +42,6 @@
"itscss": "3.1.0"
},
"devDependencies": {
"@three11/optisize": "3.0.1",
"@types/node": "18.11.19",
"@typescript-eslint/eslint-plugin": "5.50.0",
"@typescript-eslint/parser": "5.50.0",
Expand Down Expand Up @@ -88,6 +86,12 @@
"webpack-shell-plugin-next": "2.3.1",
"webpack-spritesmith": "1.1.0"
},
"resolutions": {
"got": "^11.8.5",
"http-cache-semantics": "^4.1.1",
"semver-regex": "^3.1.4",
"ua-parser-js": "^1.0.33"
},
"bin": {
"wmpats": "./bin/cli.js"
},
Expand Down
Loading