Skip to content

Conversation

Akshaykomar890
Copy link
Contributor

  • Only show blue color on first alternate key when "hold for alt keys" setting is enabled.
  • In persistent mode, all keys now show normal color.

…g#492)

Only show blue color on first alternate key when "hold for alt keys"
setting is enabled. In persistent mode, all keys now show normal color.
Copy link

github-actions bot commented Oct 6, 2025

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

github-actions bot commented Oct 6, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 7, 2025 17:49
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's working really well here, @Akshaykomar890! Great to have you taking on more issues 😊

One thing, could we ask you to till out the pull request template that's autogenerated when you open a PR the next time? Really helps with the review process if we can get the issue linked and have PRs looking generally the same as far as where the information we need is :)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2025
@andrewtavis andrewtavis merged commit 08089a2 into scribe-org:main Oct 7, 2025
6 checks passed
@Akshaykomar890
Copy link
Contributor Author

Got it! Thanks for the reminder @andrewtavis I’ll make sure to fill out the PR template properly next time and include the linked issue as well. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted as a part of Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants