Skip to content

Conversation

Akshaykomar890
Copy link
Contributor

Fix:replace custom language strings with locale codes (#493)

  • Use standard locale codes (de, sv, it, fr) instead of custom language strings to fix lowercase display issue in Android keyboard selection.

Below are the screen shots for the ref:

WhatsApp Image 2025-10-02 at 12 10 59 AM

Use standard locale codes (de, sv, it, fr) instead of custom language
strings to fix lowercase display issue in Android keyboard selection.
Copy link

github-actions bot commented Oct 1, 2025

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

github-actions bot commented Oct 1, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis andrewtavis self-requested a review October 1, 2025 18:56
@andrewtavis
Copy link
Member

Thanks so much for getting to this, @Akshaykomar890! We'll do the review soon :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and the changes are working wonderfully, @Akshaykomar890 😊 Thanks so much for a great first contribution!

CC @angrezichatterbox that the changes were reverted as we discussed and we're not good on this end :)

@andrewtavis andrewtavis merged commit 11fab91 into scribe-org:main Oct 2, 2025
7 checks passed
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted as a part of Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants