Skip to content

Conversation

DeleMike
Copy link
Collaborator

@DeleMike DeleMike commented Sep 29, 2025

Contributor checklist


Description

  • We remove the cursor in conjugate mode.
  • We also make sure the entered verb is the same colour as the command bar text colour
  • We also ensure that we clean up the states of variables properly.

Related issue

Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@DeleMike
Copy link
Collaborator Author

Hi @andrewtavis, can you check this PR out? It solved the minor issue #496.
I'm open to any further suggestions. I also made sure I took note of the dark mode.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, @DeleMike! Exactly what we're looking for 😊 So great to have the command bar be in the state that it is. Thanks for your dedication to getting it here!

@andrewtavis andrewtavis merged commit 129893d into scribe-org:main Sep 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fianlize command bar UI during conjugate

2 participants