Skip to content

fix: Work around the limit in lambda policy size #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ locals {
namespace = var.namespace
terraform = "true"
}
log_groups_to_use = length(var.log_group_prefixes) > 0 ? var.log_group_prefixes : var.cloudwatch_log_groups
}
6 changes: 4 additions & 2 deletions logs_monitoring_cloudwatch_log.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@ resource "aws_cloudwatch_log_subscription_filter" "test_lambdafunction_logfilter
}

resource "aws_lambda_permission" "allow_cloudwatch_logs_to_call_dd_lambda_handler" {
for_each = { for lg in var.cloudwatch_log_groups : lg => lg }
for_each = { for lg in local.log_groups_to_use : lg => lg }
statement_id = "${substr(replace(each.value, "/", "_"), 0, 67)}-AllowExecutionFromCloudWatchLogs"
action = "lambda:InvokeFunction"
function_name = aws_cloudformation_stack.datadog-forwarder.outputs.DatadogForwarderArn
principal = "logs.${var.aws_region}.amazonaws.com"
source_arn = "arn:aws:logs:${var.aws_region}:${var.aws_account_id}:log-group:${each.value}:*"
source_arn = (length(var.log_group_prefixes) > 0 ?
"arn:aws:logs:${var.aws_region}:${var.aws_account_id}:log-group:${each.value}*" :
"arn:aws:logs:${var.aws_region}:${var.aws_account_id}:log-group:${each.value}:*")
}
5 changes: 5 additions & 0 deletions vars.tf
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ variable "cloudwatch_log_groups" {
type = list(string)
default = []
}
variable "log_group_prefixes" {
description = "List of CloudWatch Log Group prefixes to create lambda permissions"
type = list(string)
default = []
}
variable "enable_datadog_aws_integration" {
description = "Use datadog provider to give datadog aws account access to our resources"
type = bool
Expand Down
Loading