fix: update error handling for restore#150
Merged
Merged
Conversation
Contributor
|
Fantastic, thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my testing, farraday is raising
Faraday::ResourceNotFounderrors when a get by ID request can't find a resource. The currentrescue RuntimeError => eblock is not rescuing these errors, which leads to the failure in #148. I'm guessing faraday updated their error raising at some point which caused the existing rescue block to no longer work?Resolves #148:
restoremethod to useFaraday::ResourceNotFoundget_by_idfor dashboards to add error handling for when a dashboard ID can't be found