Merge pull request #60 from screwdriver-cd/noStartTime

Fix error calculating buildDuration when there is no startTime
screwdriver-cd · Sep 30, 2016 · e4dd6be · e4dd6be
2 parents 9154148 + 7280fb9
commit e4dd6be
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/build/model.js b/app/build/model.js
@@ -25,7 +25,7 @@ export default DS.Model.extend({
   }),
   buildDuration: Ember.computed('startTime', 'endTime', {
     get() {
-      if (!this.get('endTime')) {
+      if (!this.get('endTime') || !this.get('startTime')) {
         return humanizeDuration(0);
       }
 

diff --git a/tests/unit/build/model-test.js b/tests/unit/build/model-test.js
@@ -32,9 +32,15 @@ test('it calculates buildDuration', function (assert) {
   });
 
   Ember.run(() => {
+    // valid duration
     assert.equal(model.get('buildDuration'), '10 seconds');
+    // no end time, so duration is 0
     model.set('endTime', null);
     assert.equal(model.get('buildDuration'), '0 seconds');
+    // no start time, so duration is 0
+    model.set('endTime', new Date(1472244592531));
+    model.set('startTime', null);
+    assert.equal(model.get('buildDuration'), '0 seconds');
   });
 });