fix: Remove noop plugin #39
Conversation
package.json
Outdated
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git@github.com:screwdriver-cd/artifact-bookend.git" | ||
| "url": "git+https://github.com:screwdriver-cd/artifact-bookend.git" |
There was a problem hiding this comment.
Is the format of url right? other packages look like git+https://github.com/screwdriver-cd/
https://github.com/screwdriver-cd/store/blob/master/package.json#L15
https://github.com/screwdriver-cd/models/blob/master/package.json#L12
https://github.com/screwdriver-cd/artifacts-unzip-worker/blob/main/package.json#L14
| @@ -42,9 +42,6 @@ | |||
| "screwdriver-build-bookend": "^2.3.3" | |||
| }, | |||
| "release": { | |||
There was a problem hiding this comment.
We need branches under release property for semantic release.
https://github.com/screwdriver-cd/scm-github/blob/92590fd7fd66b7a0d5157b6ef44c80a475e02dca/package.json#L57-L59
There was a problem hiding this comment.
From the description of "semantic-release", it seems that the master branch is selected by default without setting the branches.
Should I explicitly set master to avoid unintended releases?
https://github.com/semantic-release/semantic-release/blob/master/docs/usage/configuration.md#options
There was a problem hiding this comment.
Currently, GitHub uses main branch as a default branch name. This might change the default behavior of semantic releases.
I think it is better to set explicitly branch name.
There was a problem hiding this comment.
I see.
I'll fix it.
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Context
Seeing Error:
Cannot find module './node_modules/semantic-release/src/lib/plugin-noop.js'Objective
Removes old package.json section for noop plugin
References
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.