Integrate www-gui localization #2213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschamp
previously approved these changes
Oct 19, 2018
Contributor
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
Well that's simple enough!
Contributor
Author
|
I've marked this blocked so that the gui changes can land first. |
* Initialize `locales` in redux using methods exported by GUI. * pass GUI method to set the `scratchlanguage` cookie NOTE: It does not reload the page, so switching back to the project page will not reflect language changes made in gui until the next page reload. Reloading the page will lose project state so we don’t want to do that.
chrisgarrity
force-pushed
the
issue/2172-integrate-intl
branch
from
3e99c7d to
3fcc13a
Compare
Contributor
|
This was tested in a recent bug hunt. Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Fixes #2172 (along with scratchfoundation/scratch-gui#3431)
Changes:
localesin redux using methods exported by GUI.scratchlanguagecookieNOTE: The does not reload the page, so switching back to the project page will not reflect language changes made in gui until the next page reload. Reloading the page will lose project state so we don’t want to do that.
Test Coverage: