fix: wrapClamp direction during deserialization #2449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwillisf
changed the title
cwillisf
added
priority 4
Medium Severity
Low Impact
Low Severity
and removed
Medium Severity
labels
cwillisf
approved these changes
Oct 17, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
fix: wrapClamp direction during deserialization
|
🎉 This PR is included in version 2.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves scratchfoundation/scratch-gui#5806
Proposed Changes
wrapClamp direction during deserialization
Reason for Changes
Scratch 1.4 projects can have direction of -270. Since Scratch 3.0 expects direction to be -179-180, there are some bugs that is caused by this. This may break projects saved in Scratch 1.4 that uses
directionblock, but it's the 2.0 behavior anyway (see ScratchObject's setDirection behavior)Scratch 1.x projects are handled in sb2.js part. Scratch 1.x projects that are serialized to SB3 can still have this issue, so it will handle in sb3.js as well