Skip to content

Remove 'sounds' from required array in JSON schema #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mewtaylor merged 1 commit into from
Sep 11, 2017
Merged

Remove 'sounds' from required array in JSON schema #14

mewtaylor merged 1 commit into from
Sep 11, 2017

Conversation

@thisandagain
Copy link
Contributor

@thisandagain thisandagain commented Sep 1, 2017 •
edited
Loading

@thisandagain
fix($schema): Removes 'sounds' from required array in JSON schema
9322967 
Removes 'sounds' from required array in JSON schema as to resolve edge case discovered in scratchfoundationGH-13

scratchfoundationGH-13
@towerofnix
Copy link

towerofnix commented Sep 2, 2017

This also fixes #7 (the original report of this bug).

@mewtaylor mewtaylor merged commit 791bbab into scratchfoundation:develop Sep 11, 2017
@towerofnix towerofnix mentioned this pull request Sep 11, 2017
Closed
@thisandagain thisandagain mentioned this pull request May 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mewtaylor mewtaylor mewtaylor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mewtaylor mewtaylor

Labels

pr - good to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thisandagain @towerofnix @mewtaylor