Make stroke width 0 when transparent #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsih
force-pushed
the
transparentStrokeWidth
branch
from
d90a8c2 to
82baf0c
Compare
|
Code LGTM. Do you know why the checks are failing? |
|
Ah, oops! I need to fix the tests |
…itched to 0 and back
|
@benjiwheeler I got the stroke color to stay the same when you switch the width to 0 and then raise it up again, but it only works if you have something selected |
|
Fixed tests |
fsih
requested review from
benjiwheeler
and removed request for
benjiwheeler
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Fixes #279
Proposed Changes
When stroke color is transparent, make the width report 0
When stroke width is 0, make the color report transparent
When the stroke color is changed from transparent, make the width 1
When stroke width is changed from 0, make the color black
Reason for Changes
Don't have hidden properties.
When you make changes, they are visible.