-
Couldn't load subscription status.
- Fork 262
Gradient outlines part 1 #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient outlines part 1 #1166
Conversation
why my brain hurt???
A "style" refers to something that can fill/stroke a shape. Currently that's either a solid color or a gradient of some orientation. The selection gradient type reducer has been removed and folded into the "fill style" reducer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Here's the same SVG exported from scratch.mit.edu vs exported from the gradient-outlines branch: https://www.diffchecker.com/xGHcgGmX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| colorState.secondary = MIXED; | ||
| } | ||
|
|
||
| return colorState; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document the params of the return value, and note that gradientType may be null?
5fc192b to
a23fabd
Compare
|
I've changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!

Resolves
A step towards #540
Proposed Changes
This PR implements the "refactoring" half of the "gradient outlines" changes--this should contain no functional changes but cleans up the codebase in preparation for adding gradient outline support.
Reason for Changes
See above
Test Coverage
Tests have been updated accordingly