Don’t push tags to gh-pages #5194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These builds make our gh-pages branch too large for GitHub to handle.
fsih
approved these changes
Sep 20, 2019
| on: | ||
| all_branches: true | ||
| condition: $TRAVIS_EVENT_TYPE != cron && ! $TRAVIS_BRANCH =~ ^greenkeeper/ | ||
| tags: false # Don't push tags to gh-pages |
Contributor
There was a problem hiding this comment.
It says setting tags "causes the branch condition to be ignored", so I think that means you don't need the all_branches line
Contributor
Author
There was a problem hiding this comment.
From what I can tell, without all_branches, it uses the default for branch which is whichever primary branch is configured in GitHub (develop on most repos), which would cause this step to only trigger on one branch. So I think it's necessary to keep it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These builds make our gh-pages branch too large for GitHub to handle. Thanks to @fsih for deleting all those builds. This will keep them from re-populating.
@fsih I'm never sure who to assign for this type of change, so I assigned you since we talked about it. Here's the relevant part of Travis' docs. https://docs.travis-ci.com/user/deployment/#conditional-releases-with-on