Skip to content

Conversation

@benjiwheeler
Copy link
Contributor

Resolves

Proposed Changes

Instead of auto-saving whenever a logged in user clicks the Share or See project page buttons, before sharing or navigating to the project page, only auto-save if the project has changed.

Reason for Changes

It's slow to auto-save unnecessarily. This is part of the larger effort to make saving happen at the right times, and only at the right times.

Test Coverage

No tests written yet; should write some

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

@benjiwheeler benjiwheeler added this to the April 2019 milestone Apr 1, 2019
@benjiwheeler benjiwheeler self-assigned this Apr 1, 2019
@towerofnix
Copy link
Contributor

Thank you! This is definitely an appreciated change. It's a little frustrating to always have to make sure the screen is exactly as you want the project thumbnail to be whenever you see-outside the project. (Especially if you'd just seen-inside and hadn't made any changes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'See project page' button should not save unless project has changed

3 participants