Use the loading screen in player mode #4210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @paulkaplan. This looks minimal enough, but I'll defer to you and @rschamp re: launch risk. This certainly would help initial loading feel more responsive to the user. |
rschamp
approved these changes
Dec 27, 2018
Contributor
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
I'm for landing this for launch since I think it looks a little broken at the moment for large projects. I also think it's highly visible but pretty well-contained if we decide we want to pull it out for some reason after launch.
Contributor
|
@rschamp Sounds good. @paulkaplan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Use the loading animation in player mode as well as editor mode.
Reason for Changes
Explain why these changes should be made
The lack of loading animation makes the project page view feel like it isn't working.
Here is what it currently looks like
With this change it looks like this
I simply passed in the loading prop to the stage wrapper so that it can be shown in player only mode.
I also changed the CSS for the loading animation so that it is position absolute instead of fixed, so that it can be contained within the stage size in player mode (but is still full screen in editor mode, which I made sure to test)
/cc @thisandagain @rschamp I made this because i was concerned about the way the project page felt using larger projects. We can talk offline about whether you think this should go in before release or not.