Fix cursors #4184
Closed
Fix cursors #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@epicfaace this seems to fix the cursor issue, but brings back the issue that #2584 fixed. The drag surface that should have pointer events cancelled does not ever get the blocklyDraggingMouseThrough class. |
|
@epicfaace I'm going to close this since #5078 fixes this issue without the related stack click issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #2755 - Drag cursor (and delete cursor) disappears from block after starting drag.
Proposed Changes
Essentially, this PR makes a small difference to the changes done to fix issue #2584.
Rather than disabling pointer events for elements with class
blocklyBlockDragSurface(which ends up disabling the delete and other cursors as well), this solution disables pointer events for classblocklyDraggingMouseThrough. See https://github.com/LLK/scratch-blocks/blob/develop/core/block_svg.js#L1029Reason for Changes
Fixes cursor issues.
Test Coverage
None
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet