refactored font loading state to be in redux #4160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsih
reviewed
Dec 20, 2018
Contributor
fsih
left a comment
fsih
left a comment
There was a problem hiding this comment.
LGTM too, just had a question
| }; | ||
| default: | ||
| break; | ||
| return; |
Contributor
There was a problem hiding this comment.
I don't understand this change. It might help to add a comment explaining how you could get into this state, and what you are doing in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
instead of maintaining the state of font loading in the
font-loader-hoc, put it into redux.Reason for Changes
We need font loading state to be shared across project page and editor, so that fonts are not loaded a second time.
The second font load was triggering a second vm load of the project data.
Test Coverage
none... not obvious what we would test
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet