On modal mount, push history if current history state doesn't match this modal's id #4144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjiwheeler
force-pushed
the
library-history2
branch
from
29eee7a to
67074ed
Compare
kchadha
reviewed
Dec 20, 2018
test/helpers/selenium-helper.js
Outdated
| elementIsVisible (element) { | ||
| return this.driver.wait(until.elementIsVisible(element)); | ||
| } | ||
| elementIsNotVisible (element) { |
Contributor
There was a problem hiding this comment.
We should probably remove this since it's not being used anywhere
kchadha
approved these changes
Dec 20, 2018
Contributor
kchadha
left a comment
kchadha
left a comment
There was a problem hiding this comment.
LGTM! In the future I think we should probably add something like this to tab switching as well (e.g. costumes/sounds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Currently, on modal mount, we adjust the
window.history. Ifhistory.state === null, we push a new history entry; if it's not null, we just replace history.The problem with this is that if we've already navigated within the single page application, say from the project page to editor, then
history.stateis not null; so we just replace history when the library modal is open. Then if the user hits the back button, the browser navigates back to the previoushistoryentry -- in this case, the project page.This change instead checks
history.state === null || history.state !== this.id, which is more permissive; if thehistory.stateentry exists but is not the same as the current view, we push, instead of replacing.Reason for Changes
Browsing was behaving in an unexpected, frustrating way.
Test Coverage
I added a test of the back button functionality, but note that it doesn't actually fail if this code change isn't included. Still, I think it's good to have.
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet