Disconnect from cloud when entering editor mode on someone else's project #3890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… editor mode without the ability to save.
kchadha
commented
Nov 27, 2018
| // This should cover info about the website specifically, like scrather status | ||
| return !!(props.cloudHost && props.username && props.vm && props.projectId); | ||
| } | ||
| shouldNotModifyCloudData (props) { |
Contributor
Author
There was a problem hiding this comment.
This is not a great name, but writing this function so that the name is not a negative check makes the code less readable...
rschamp
previously approved these changes
Nov 28, 2018
kchadha
force-pushed
the
editor-cloud-disconnect
branch
from
7e9d7a3 to
9fc6d85
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Reason for Changes
Prevents users from modifying cloud data when editing someone else's project.
Test Coverage
Added unit tests for the new functionality.
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet