Revise alerts code to clarify and reorganize alert type handling #3867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjiwheeler
changed the title
rschamp
suggested changes
Nov 26, 2018
Contributor
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
I think the only thing important to change or remove is the SHOW_ALERT comment, since it's still confusing/possibly misleading.
benjiwheeler
force-pushed
the
alerts-revise
branch
from
8a70a90 to
0ce9f3c
Compare
rschamp
previously approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Reason for Changes
routine code improvement