Move URL query string handling into an HOC #3798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cc @ericrosenbaum this will also handle the all tutorials |
benjiwheeler
previously requested changes
Nov 16, 2018
benjiwheeler
added
pr - good to merge
pr - changes requested
and removed
pr - changes requested
pr - good to merge
labels
This will work better if there are other query string options that need to be handled later. It also handles the distinction between ‘all’ and the other tutorials better.
chrisgarrity
force-pushed
the
feature/refactor-all-tutorials
branch
from
38b4ca8 to
abf93ed
Compare
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Refactors query string handling into an HOC
Proposed Changes
Consolidates all the special handling of tutorial query strings into one place.
Reason for Changes
Easier to understand and maintain.
Test Coverage
Updated the unit tests to reflect the refactored tutorial URL handling. Also manually checked.
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet