added author-info, user-avatar components #3681
Conversation
benjiwheeler
force-pushed
the
show-creator
branch
from
d4ce1bf to
0a1c00f
Compare
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
This looks pretty good, thank you for extracting the avatar into its own component. I think the only things I'm really concerned about changing is how the author thumbnail url is constructed, and the localization of the author byline.
| > | ||
| <UserAvatar | ||
| className={styles.avatar} | ||
| userId={userId} |
There was a problem hiding this comment.
I think we should be passing a full url as src from the outside rather than constructing the url from a userId here. The details of the path, and even the host are outside the responsibility of GUI. It's possible eventually an environment (offline?) would pass in a dataURI, for instance. And in the immediate, we would want to use a different thumbnail hosts in local development, on staging, and in production.
There was a problem hiding this comment.
Do we want this to link to the author's profile? @carljbowman?
If so, we should accomplish it with an onAuthorClick (or something) prop, since we'd want that to be handled differently in the desktop editor.
There was a problem hiding this comment.
Could also circle back to this.
benjiwheeler
added
pr - needs review
needs discussion
and removed
pr - changes requested
labels
benjiwheeler
force-pushed
the
show-creator
branch
2 times, most recently
from
5e108b3 to
91a65fd
Compare
benjiwheeler
force-pushed
the
show-creator
branch
from
91a65fd to
5681bd9
Compare
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
Looks good, although the bool or string types seem unnecessary.
3 participants
(Needs scratchfoundation/scratch-www#2289 before it will work)
Resolves
Proposed Changes
uses author id and author username to create a display of info about the project's creator:
Reason for Changes
Display info on the creator! And, have a place to show the title.