-
Notifications
You must be signed in to change notification settings - Fork 4k
Sound library update #3385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sound library update #3385
Conversation
|
Do you take requests? I think the "Happy Birthday to you" song could stand to be upgraded. It's just called "Birthday" in the Scratch 3.0 sound library (and is called Birthday Bells in Scratch 2.0) The song and Lyrics are now in the public domain. You can list it (or a replacement) by its full title which would make it easier to find. This song is very popular and I believe that beginners would use it for inspiration in their projects if a better version was included with Scratch. (The current version is just the melody play on xylophone). I have a "test case" here of a version that I arranged and played on my keyboard. https://scratch.mit.edu/projects/248022990/ Also, and I'm sure you know this, but not all recordings will be in the public domain. Individual arrangements and performances might still be copyrighted. |
The character in that album is called "Sita", not "Sitar". ("Sita Flute Raag", "Sita Returns to Mother Earth", etc.) So should this Scratch song b e called "Dance Sita", not "Dance Sitar"?
This is actually called Nephlim ("phlim" vs. "philim") on freesound.org. |
|
@towerofnix ah! true, it's from a movie called "Sita Sings the Blues," but I called the track that because it features the sound of a stringed instrument called a sitar. |
|
@ericrosenbaum today I learned! - I never heard of the sitar before. Neat :) |
thisandagain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code review is a little weird because we had lots of conversation IRL, but here you go! :-P
src/lib/libraries/sounds.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "Reggae Nine Miles", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/lib/libraries/sounds.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "Nephilim", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/lib/libraries/sounds.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "Variations 1", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/lib/libraries/sounds.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "Trapped", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/lib/libraries/sounds.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "Melodic Dubstep", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/lib/libraries/sounds.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "Inhale", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/lib/libraries/sounds.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "Energetic Dance", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/lib/libraries/sounds.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "Bossa Bossa", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/lib/libraries/sounds.json
Outdated
| "tags": [] | ||
| }, | ||
| { | ||
| "name": "Air Hockey Saloon", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
src/lib/libraries/sounds.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "name": "Send For The Horses", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@Mr-Dave2 thanks for the suggestion! I agree that our happy birthday could use an upgrade :) |
Resolves
Resolves #2710
Resolves #2844
Proposed Changes
Air Hockey Saloon - Chris Zabriskie
Bossa Bossa - Kevin MacLeod
Darkling - Kevin MacLeod
Energetic Dance - furbyguy
Dance Sitar - Nina Paley
Variations 1 - Kimiko Ishizaka
Inhale - Peter Rudenko
Melodic Dubstep - Orboscope
Mystery - tyops
Nephilim - Flick3r
Pookatori and Friends - Kevin MacLeod
Reggae Nine Mile - Nueve Millas
Send for the Horses - Kevin MacLeod
Trapped - Kellee Maize
Reason for Changes
This is progress toward a more diverse and higher quality library of music loops for people to use in their projects (and a couple of minor fixes).