disable onShare button #3354
Merged
disable onShare button #3354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgarrity
suggested changes
Oct 11, 2018
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
Need to remove the proptype
| onClickSave: () => dispatch(saveProject()), | ||
| onSeeCommunity: () => dispatch(setPlayer(true)), | ||
| onShare: () => {} // NOTE: implement this | ||
| onSeeCommunity: () => dispatch(setPlayer(true)) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
chrisgarrity
approved these changes
Oct 11, 2018
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
After discussion - the presence or absence of the prop determines whether the button is active. Removing it from mapDispatchToProps is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by putting in an empty default onShare function, I had inadvertently made the button appear enabled in beta/standalone.