Set lang attribute for screen readers #3132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgarrity
suggested changes
Sep 13, 2018
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
One little picky detail. Otherwise I think this looks fine.
src/containers/language-selector.jsx
Outdated
| bindAll(this, [ | ||
| 'handleChange' | ||
| ]); | ||
| document.documentElement.lang = this.props.currentLocale; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Contributor
Author
|
@chrisgarrity When switching back to www the locale set in the gui is still set as attribute. Is this an issue I should worry about for now? |
chrisgarrity
approved these changes
Sep 24, 2018
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
This looks fine. I don't think there's anywhere that we use the lang attribute on www (definitely not in the gui), although perhaps we should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
#3049
Proposed Changes
Sets the lang attribute of the document in the GUI
Reason for Changes
Setting the correct language is crucial for screen readers so they use the correct pronounciation
Test Coverage
MacOS, Chrome, not tested with a screen reader