Some costumes only display in the paint editor and not on the stage

[kchadha]

Expected Behavior

Costumes should display in the stage.

Actual Behavior

In the following projects, animations look really blinky (this is not how the project runs in scratch 2.0). Looking inside, it looks like many of the costumes are not rendering on the stage at all:

#82443924 - takes a long time to load, Sprite1 and Sprite2 manifest the issue; the following is a sprite with fewer costumes (costumes 1 - 18 are broken in this sprite among others); rename to .sprite3

broken-costumes.zip

#244084125 - Sprite3 and Sprite5 in this project manifest the issue

[griffpatch]

I have experienced this on numerous projects, usually vector costumes, where one costume appears black in the thumbnail of the costume editor and on stage, bit appears fine in the paint editor itself. By simply moving the costume slightly in the paint editor it fixed itself.

…

On Sat, 26 Jan 2019, 03:50 Karishma Chadha ***@***.*** wrote: Expected Behavior Costumes should display in the stage. Actual Behavior In the following projects, animations look really blinky (this is not how the project runs in scratch 2.0). Looking inside, it looks like many of the costumes are not rendering on the stage at all: #82443924 - takes a long time to load, Sprite1 and Sprite2 manifest the issue; the following is a sprite with fewer costumes (costumes 1 - 18 are broken in this sprite among others); rename to .sprite3 broken-costumes.zip <https://github.com/LLK/scratch-gui/files/2798487/broken-costumes.zip> #244084125 - Sprite3 and Sprite5 in this project manifest the issue — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4435>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGbNvnsNkRlgXGZR797IX9vYwpiXQFt5ks5vG9CYgaJpZM4aT-Bj> .

[kchadha]

@griffpatch, I thought to try moving/editing the costumes to see if that fixes the issue, but it doesn't seem to (at least not with the costumes in the first project listed there)

[thisandagain]

/cc @paulkaplan @picklesrus @ktbee @mzgoddard @cwillisf @BryceLTaylor

[cwillisf]

TL;DR: I think this is still needs-repro.

Both projects load and run correctly for me with no blinking or flickering during the animation. All frames of animation seem to be present.

The broken-costumes.zip sprite seems to be missing a bunch of costumes: the costume names go costume1, costume2, ..., costume26, costume322, costume323, skipping costumes 27-321. That's consistent with the JSON and SVGs contained within the ZIP, though, so Scratch 3.0 is loading the data accurately. I guess the problem happened before exporting the sprite and the export just faithfully preserved the broken state?

If anyone (@kchadha?) can still get the broken behavior on project 82443924 or 244084125 then this might be specific to certain configurations. If not, maybe this issue or those projects have been fixed within the last 4 days.

[paulkaplan]

@cwillisf i also could not repro on chrome 71. But using chrome 69, i was able to get some costumes to not show up on the stage. I noticed these projects have a ton of costumes, I'm wondering if it is a video memory/texture loading/webgl problem, since downloading the costumes that do not show up and re-uploading them to a different project display just fine.

[paulkaplan]

@griffpatch did you mean "black" or "blank". I'm seeing the issue (on chrome 69) in the project @kchadha gave where the costume is blank on the stage only (appears fine in costume editor, costume tile and sprite tile). But if you are seeing the costume appear black in the thumbnails/stage, that sounds like a different (and bad!) issue. Could you give a project link where you've seen this, as well as what browser/version/OS you saw it with?

[griffpatch]

I have a repo for this... It occurs with a single perfectly horizontal line in the vector editor.

1. Just start a new costume
2. choose the line tool
3. Hold down 'shift' and drag a line across the screen.

At this point the costume will be displaying in the editor, but not in the project or thumbnail
Adding a second line will make both lines visible (even if horizontal), and removing it again will make it invisible.

I suspect that the height of the costume is being calculated as 0 even if the line is very thick? This is then causing the image to not be displayed...

Am I right in thinking the issue of counting thick lines in a costumes dimensions might have been addressed in another issue/log too?