Block editors not being hidden by modals when embedded

[paulkaplan]

This problem only impacts gui when it is embedded in the project page. This does not happen on the standalone beta build.

If you open the note picker or angle picker, then open the extensions library (for example) you still see the field above the modal.

It seems that this code to hide the block editors is not running when opening modals when the GUI is embedded in WWW https://github.com/LLK/scratch-gui/blob/develop/src/containers/blocks.jsx#L133-L135

My best guess is that the state tree may be different and the anyModalVisible prop may not be setting correctly in mapStateToProps https://github.com/LLK/scratch-gui/blob/develop/src/containers/blocks.jsx#L558-L561

Thanks to @picklesrus for finding this

[paulkaplan]

This is caused by having the GUI consume a prop to hide the preview modal but not updating the store to set the modal.previewInfo to false. So anyModalVisible is always true, causing hideChaff to never be called.

[paulkaplan]

The solution to this is just to make the default of modals.previewInfo false, and have it possible to toggle to true via AppStateHOC.