New list cannot be deleted by right click

[renlj]

New list can not be deleted by right mouse button, right key can be deleted in scratch2.0

[Wgil]

Hello,

How can I reproduce it?

[alexmotoc]

Go to Variables and create a new list. Try right clicking on the list you've just created and there is no menu to delete present. This functionality is available in 2.0 and also for normal variables.

Expected behaviour:

Am I correct? I could try to look into this - I am a beginner with React and new to this codebase but feel it will be a good way to make my first open source contribution!

[joker314]

Yeah, that's right!

---

Should we also add a 'rename list' option (this is not available in 2.0 for lists, but is for variables)

[alexmotoc]

I was looking into it and figured out that I need to edit this file to add the new context menu - https://github.com/LLK/scratch-blocks/blob/develop/blocks_vertical/data.js

After cloning both repos and installing them I linked scratch-blocks to scratch-gui (so block changes are picked up when I run npm start from the gui) using:
npm link (inside scratch-blocks)
npm link scratch-blocks (inside scratch-gui)

The problem is when I make a simple change such as editing a message constant, it doesn't seem to be picked up even if I restart the server.

Can someone please help me? Sorry if it's a silly question but I have no experience with node and I feel a bit stuck.

[towerofnix]

@alexmotoc Unfortunately, to make scratch-gui see your changes, you need to re-build the entire scratch-blocks (in my experience), by doing npm run prepublish. (And then you have to restart the gui server, since it won't automatically detect that scratch-blocks was updated.)

Do note that you can test your scratch-blocks changes simply by opening the tests/vertical_playground.html file in your web browser, though. That will automatically adjust to changes you make in the source code. You don't even have to rebuild scratch-blocks, just reload the webpage.

Maybe only relevant if you're on Linux/Mac, but my steps for linking scratch-blocks are "manual" - I don't use npm link:

scratch-gui $ npm install
scratch-gui $ rm -rf node_modules/scratch-blocks
scratch-gui $ ln -s ~/Documents/scratch-blocks node_modules/scratch-blocks
# You don't need to do anything in scratch-blocks with this method of linking
# (besides rebuilding with npm run prepublish, of course).

Oh, and by the way, welcome! That's not a silly question at all. It's always good to see and help out another developer :)

[alexmotoc]

@towerofnix Thanks a lot! I ended up testing the changes using the tests/vertical_playground.html file and it was sufficient for my needs.

I opened a pull request in the other repo - scratchfoundation/scratch-blocks#1715. Will wait for a review. I am not too happy about almost duplicating the other context menu. Was wondering if there was a good way to refactor that and keep it in one function since they are basically identical.

[towerofnix]

This is fixed now and should be closed.