Skip to content

[UEPR-501] Green flag button receives focus and prevents the project from capturing keyboard events #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adzhindzhi merged 1 commit into from
Feb 3, 2026
+12 −2
Merged

[UEPR-501] Green flag button receives focus and prevents the project from capturing keyboard events #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/scratch-gui/src/components/green-flag/green-flag.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import classNames from 'classnames';
import PropTypes from 'prop-types';
import React from 'react';
import React, {useCallback} from 'react';

import greenFlagIcon from './icon--green-flag.svg';
import styles from './green-flag.css';
Expand All @@ -13,10 +13,20 @@ const GreenFlagComponent = function (props) {
title,
...componentProps
} = props;

// Unfocus so project stage can capture keyboard events for
// blocks that react to arrow movement for example
const handleOnClick = useCallback(e => {
onClick(e);

const target = e.currentTarget;
if (target) target.blur();
}, [onClick]);

return (
<button
className={styles.greenFlagButton}
onClick={onClick}
onClick={handleOnClick}
{...componentProps}
>
<img
Expand Down
Loading