Fix hat block spacing #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisandagain
approved these changes
Mar 13, 2017
|
Landing for test. @rachel-fenichel happy to revert after testing if desired. |
paulkaplan
pushed a commit
to paulkaplan/scratch-blocks
that referenced
this pull request
May 5, 2017
…procedure_rename Use setValue in fieldTextInput so that procedure renaming works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Fixes #838
Proposed Changes
Describe what this Pull Request does
Adds
Blockly.BlockSvg.START_HAT_HEIGHTto the y offset in the flyoutlayoutmethod for hat blocks. This offset was being added to the top, but not to the y offset for the bottom, squishing blocks together.Reason for Changes
Explain why these changes should be made
Bug reported #838
Incidentally this problem actually already existed, it just wasn't as obvious because of the previous large spacing. You can tell looking back before the margin that something wasn't right:
Test Coverage
Here are some before/after screenshots:
Before
After
