Skip to content

Build playgrounds for gh-pages #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2017

Conversation

rschamp
Copy link
Contributor

@rschamp rschamp commented Dec 24, 2016

Sets up the necessary structure in the gh-pages directory to run the uncompressed playgrounds. Deploy the gh-pages directory to the gh-pages branch after publishing to NPM.

Adds a landing page at the root to go to the horizontal and vertical playgrounds. Everything in tests is available under /playgrounds/tests/ though.

Sets up the necessary structure in the gh-pages directory to run the uncompressed playgrounds. Deploy the gh-pages directory to the gh-pages branch after publishing to NPM.
@TheBrokenRail
Copy link
Contributor

How about instead of copying the current playground create a compressed playground that uses the dist importable modules to make the playground more compact.

# Publish to gh-pages as most recent committer
git config --global user.email $(git log --pretty=format:"%ae" -n1)
git config --global user.name $(git log --pretty=format:"%an" -n1)
npm run --silent deploy -- -x -r https://${GH_TOKEN}@github.com/${TRAVIS_REPO_SLUG}.git

This comment was marked as abuse.

This comment was marked as abuse.

@cwillisf
Copy link
Contributor

@TheBrokenRail: the playgrounds attached to Scratch 3.0 repositories are intended for a few purposes: they demo the project or module, but they also offer a place to debug and learn about that module through live tinkering. Your suggestion would potentially benefit people who are interested in using the playground as a demo, especially if they're in an environment where downloads are slow or expensive, but would likely make debugging and learning about the module more difficult.

Copy link
Contributor

@thisandagain thisandagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @rschamp

@rschamp rschamp merged commit 729c4b5 into scratchfoundation:develop Jan 3, 2017
@rschamp rschamp deleted the bugfix/744 branch January 3, 2017 15:23
rachel-fenichel pushed a commit to rachel-fenichel/scratch-blocks that referenced this pull request Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants