-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Extensions Take 2 #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Extensions Take 2 #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blockly.Extensions.loadExtension(
"Blockly.Extensions.EXTENSIONS.push([{"type":"Block Type","spec":"Demo","id":"Block Spec","run":"Function Object"}]);"
); First - that's an invalid string. Second - why not just do |
Thanks @TheBrokenRail but as per my comment on your last PR we are not interested in adding features that will likely be fundamentally redesigned such as Extensions at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Actually Works!
I've tested block shapes and the toolbox both seem to work well.
Changes Since Last Time
Lots of bugs fixed, now imports in objects not JSON. Has a import function that takes JavaScript code. JavaScript code would be used to create and push the object. Also, because of lookup function you can store data on the block object such as a function to run in a implementation.
Loader Script Example
JS Object Example
Block Types
Defaults and Changes
Why JavaScript Code
You need something to create the objects and you might want to run other code.
Example Implementation For Scratch-VM
Input Types