Sort list variables in context menu #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchadha
reviewed
May 24, 2019
kchadha
reviewed
May 24, 2019
There was a problem hiding this comment.
@towerofnix, there's just a stray newline, but otherwise this looks good. Sorry this took so long to review!
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
No issue, but it'd be corresponding to #1879.
Proposed Changes
This is the exact same PR as #1888 from a couple months ago but for lists now. It sorts the variable (list) options in the list right-click menu.
Reason for Changes
Consistency with other menus in Scratch 3.0.
Test Coverage
Tested manually (created lists "a, z, b", dragged out an "a" block, then right-clicked it - on develop it shows "z, b", on this PR it shows "b, z" correctly).