Fixed lack of category identifiers #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was changing CSS via a userscript, I noticed that a few blocks were not being affected. Looking at the code I noticed that those specific blocks did not have the `"category": Blockly.Categories.sound,` property. This simple change should fix the problem. (There is one more block with this issue, and that is the "When backdrop switches to" block. I will also fix that in a hotsecond)
|
Any reason this can't be merged? |
|
The ST just haven't gotten around to looking at this pull. Please note, however, that you should (actually, must, but you've already opened it) open an issue for problems like this before sending in pulls - and the issue must be labelled "help wanted" before the ST will accept outside pulls for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was changing CSS via a userscript, I noticed that a few blocks were not being affected. Looking at the code I noticed that those specific blocks did not have the
"category": Blockly.Categories.sound,property. This simple change should fix the problem. (There is one more block with this issue, and that is the "When backdrop switches to" block. However, looking at it, it appears that this block does have a category definition, making that cause unknown)Resolves #1509