Extract code for rendering the right side of a reporter #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping. |
griffpatch
pushed a commit
to griffpatch/scratch-blocks
that referenced
this pull request
Oct 12, 2017
Edit generators to read in Variable Models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #1106 and is intended to be merged after the other. The new code is in the second commit.
Resolves
None
Proposed Changes
Cleanup of code in renderDrawRight_. This creates a separate function for drawing the correct right-side edge shape for a reporter.
Reason for Changes
Code readability: breaks rendering code into named pieces with explanations of what each piece of code does and where it expects to start drawing. There's no change in behaviour.
Test Coverage
Visually confirmed that all blocks render and look good in the vertical playground.