Add glide (number) secs to [drop down] block #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericrosenbaum seeing as you’re requested for review, any comments? /cc @thisandagain |
|
@ericrosenbaum updates? /cc @towerofnix |
|
These changes look good to me (though I'm obviously not one of the assigned reviewers!). (Also, it's awesome that the order of definitions in |
|
@towerofnix Yes, I noticed that and made the change comply with that convention :) Alright then - merge when you will :D |
|
One more fix- the default value for seconds, 1, is not getting read in correctly. We just need to change |
|
@ericrosenbaum Done! Merge when you will! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
scratchfoundation/scratch-gui#598
Proposed Changes
Adds the “glide (number) secs to [drop down]” block to
motion.jsanddefault_toolbox.jsComes with scratchfoundation/scratch-vm#662 and scratchfoundation/scratch-gui#634