Skip to content

Bugfix/horizontal toolbox #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Diamg
Copy link

@Diamg Diamg commented Aug 10, 2017

Resolves

What Github issue does this resolve (please include link)?
resolve #1038

Proposed Changes

Describe what this Pull Request does
Some style changes

Reason for Changes

Explain why these changes should be made

Test Coverage

Please show how you have added tests to cover your changes

@paulkaplan
Copy link
Contributor

@rachel-fenichel i'm totally unfamiliar with this part of the code. The commented out code in part of the autoclose conditional makes me... concerned. Would you be able to to take a look at this?

@rachel-fenichel
Copy link
Collaborator

The commented out mouse listeners will be a problem for sure. @Diamg please fix all commented out code--either remove it or add it back.

@paulkaplan
Copy link
Contributor

@Diamg thanks for submitting this. There seem to be two big things going on with the horizontal layout:

  1. Some old code relating to auto-closing flyouts referenced a function that was probably removed in a merge, called createBlockFunc_. This error is blocking the layout of the blocks, causing them to all overlap in the top left corner. That functionality is now handled by blockMouseDown_ gesture handler, so those calls can be removed safely.

  2. The category menu is not styled to display horizontally. We are going to be changing the category menu quite a bit very soon (Vertical category menu #1052) so I don't think we want to address that here.

So I'll close this PR and just submit the part related to (1), thanks for pointing us in the right direction.

@paulkaplan paulkaplan closed this Aug 25, 2017
msintov pushed a commit to msintov/scratch-blocks that referenced this pull request Sep 2, 2017
field_angle renders degree symbol consistently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbox layouts "top" and "bottom" are broken in toolboxes with categories
4 participants