Fix the extraction of extension information #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalPawlicki
force-pushed
the
fix-extensions-bugs
branch
from
f0144ce to
344cf87
Compare
cwillisf
approved these changes
Mar 17, 2025
Contributor
cwillisf
left a comment
cwillisf
left a comment
There was a problem hiding this comment.
These workarounds seem reasonable. Seems like we should add some/more logic in scratch-parser for these fields, but I guess we'd want more thorough testing for that considering how widely we use scratch-parser...
Merged
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix the bugs that sometimes occur during the extraction of extensions.
Reason for Changes
The library:
extensionsfield in an SB3 project JSON is an object, thenextensions.countin the analysis result isundefined.infofield is missing from an SB2 project JSON.scratch-parserdoesn't enforce the presence or shape of theextensionsfield in the SB3 schema, orinfoin the SB2 schema, soscratch-analysishas to check these values itself.Test Coverage