Return more info on analyzed project file #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalPawlicki
force-pushed
the
DPR-527-more-info-on-analyzed-file
branch
from
30f1c31 to
a76a280
Compare
MichalPawlicki
changed the title
MichalPawlicki
force-pushed
the
DPR-527-more-info-on-analyzed-file
branch
from
a76a280 to
2a290dc
Compare
Add projectVersion and isZip to analysis results.
MichalPawlicki
force-pushed
the
DPR-527-more-info-on-analyzed-file
branch
from
2a290dc to
12d487c
Compare
cwillisf
reviewed
Jan 21, 2025
Contributor
cwillisf
left a comment
cwillisf
left a comment
There was a problem hiding this comment.
The code looks good to me. What do you think about isBundle instead of isZip? If we later add support for Scratch 1.4 SB files, it seems like we'd either need to add scratch-parser's isLegacy flag or overload isZip to mean isBundle more generically.
Contributor
Author
|
@cwillisf Makes sense, I renamed |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Proposed Changes
Add
projectVersionandisZipto analysis results.Reason for Changes
Currently the library doesn't return any info on:
project.jsonfile or ansb2/sb3bundle (ZIP file).Return these two data points, so that an additional invocation of
scratch-parseris not needed to determine them.Test Coverage