Skip to content

changing basic_auth_header flavor to b64encode instead of urlsafe_b64encode #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

gsweiz
Copy link
Contributor

@gsweiz gsweiz commented Oct 7, 2022

Fixes #181

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #192 (7ae5074) into master (81b54a5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   96.04%   96.02%   -0.02%     
==========================================
  Files           7        6       -1     
  Lines         480      478       -2     
  Branches       93       92       -1     
==========================================
- Hits          461      459       -2     
  Misses          9        9              
  Partials       10       10              
Impacted Files Coverage Δ
w3lib/http.py 100.00% <100.00%> (ø)
w3lib/__init__.py

@wRAR wRAR merged commit e13f6a0 into scrapy:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

basic_auth_header uses the wrong flavor of base64
3 participants