Remove deprecated code #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 94.40% 93.72% -0.69%
==========================================
Files 7 6 -1
Lines 465 430 -35
Branches 92 88 -4
==========================================
- Hits 439 403 -36
- Misses 16 19 +3
+ Partials 10 8 -2
|
wRAR
approved these changes
Mar 24, 2021
|
Should #150 be closed? |
elacuesta
approved these changes
Mar 24, 2021
Suffice to say, I had forgotten about it, and I did not bother checking for related pull requests. |
kmike
reviewed
Mar 26, 2021
| import warnings | ||
| from io import BytesIO | ||
|
|
||
| from w3lib.util import unicode_to_str |
There was a problem hiding this comment.
would you mind adding deprecation warnings to these functions? I think this was the only place unicode_to_str is used, and the names are all wrong
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150