Add skip-tls-verify option #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you ran a linter. Can you submit a PR that only makes the necessary changes? |
added 2 commits
October 28, 2022 14:09
This reverts commit 16ffb38.
|
I've removed the linting and only changed the necessary code, I haven't updated the version file yet though. |
jpmckinney
reviewed
Jan 3, 2023
Comment on lines
+227
to
+234
| res = requests.post( | ||
| url, data=body, headers=headers, verify=not skip_tls_verify | ||
| ) | ||
| if res.ok: | ||
| _log("Server response (%s):" % res.status_code) | ||
| else: | ||
| _log("Deploy failed (%s):" % res.status_code) | ||
| _log(json.dumps(res.json(), indent=3)) |
There was a problem hiding this comment.
This code is not equivalent to _http_post, which print()'ed successful responses without indentation, didn't print anything on URLError and tried to do more on HTTPError.
I recommend just keeping _http_post as-is and making this a much more minimal PR.
|
Closing as abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #114