Skip to content

Test & typing adjustments #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Test & typing adjustments #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/tests_asyncio/test_playwright_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
TimeoutError as PlaywrightTimeoutError,
)
from scrapy import Spider, Request, FormRequest
from scrapy.http import Response

from scrapy_playwright.handler import DEFAULT_CONTEXT_NAME
from scrapy_playwright.page import PageMethod
Expand All @@ -28,7 +27,7 @@ class DialogSpider(Spider):

name = "dialog"

def parse(self, response: Response, **kwargs) -> None:
def parse(self, **_kwargs) -> None:
return None

async def handle_dialog(self, dialog: Dialog) -> None:
Expand All @@ -37,6 +36,8 @@ async def handle_dialog(self, dialog: Dialog) -> None:


class MixinTestCase:
browser_type: str

@pytest.fixture(autouse=True)
def inject_fixtures(self, caplog):
caplog.set_level(logging.DEBUG)
Expand Down
Loading