Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DBError on close, converted to use Pipenv and few other updates #24

Closed
wants to merge 1 commit into from

Conversation

ouahibelhanchi
Copy link

  • Converted to use Pipenv
  • Attempt to close database handle only if the database has been opened
  • Renamed variables to avoid shadowing built-in functions (e.g: dir)
  • Catching exception DBError instead of the too general exception Exception
  • Defined database attribute inside init

Attempt to close database handle only if the database has been opened
Renamed variables to avoid shadowing built-in functions
Catching exception DBError instead of the too general exception
Exception
Defined database attribute inside __init__
@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #24 into master will decrease coverage by 2.41%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage    91.3%   88.88%   -2.42%     
==========================================
  Files           2        2              
  Lines          69       72       +3     
  Branches        9       10       +1     
==========================================
+ Hits           63       64       +1     
- Misses          3        4       +1     
- Partials        3        4       +1
Impacted Files Coverage Δ
scrapy_deltafetch/middleware.py 88.57% <87.5%> (-2.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea3c34...2e5575e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant