Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock tests as if running inside a scrapy project #11

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Mock tests as if running inside a scrapy project #11

merged 1 commit into from
Dec 7, 2016

Conversation

redapple
Copy link
Contributor

A recent change in scrapy makes scrapy.utils.project.project_data_dir return value depend on being in a scrapy project or not (see scrapy/scrapy#1581)

This mocks the tests assuming they are run inside a scrapy project.

@codecov-io
Copy link

codecov-io commented Nov 10, 2016

Current coverage is 91.30% (diff: 100%)

Merging #11 into master will not change coverage

@@             master        #11   diff @@
==========================================
  Files             2          2          
  Lines            69         69          
  Methods           0          0          
  Messages          0          0          
  Branches          9          9          
==========================================
  Hits             63         63          
  Misses            3          3          
  Partials          3          3          

Powered by Codecov. Last update c135544...e0b7118

@redapple redapple merged commit c9b36fc into scrapy-plugins:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants