Travis wapiti #67
Merged
Travis wapiti #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmike
reviewed
Aug 27, 2018
webstruct/wapiti.py
Outdated
| @@ -124,6 +124,10 @@ def merge_top_n(chains): | |||
|
|
|||
|
|
|||
| class WapitiCRF(BaseSequenceClassifier): | |||
| """ | |||
| >>> run_command(['which', WapitiCRF.WAPITI_CMD], verbose=False) | |||
There was a problem hiding this comment.
I think it should be moved to regular tests - WapitiCRF is a public class, its docstring should show its description and usage examples.
kmike
reviewed
Aug 27, 2018
| @@ -29,6 +29,8 @@ addons: | |||
|
|
|||
| install: | |||
| - pip install -U pip tox codecov | |||
| - git clone https://github.com/Jekub/Wapiti /tmp/wapiti | |||
| - pushd /tmp/wapiti && make && sudo make install && popd | |||
There was a problem hiding this comment.
👍
heh, I wonder why does it work - we're using sudo: false on top of travis.yml
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 81.02% 81.05% +0.03%
==========================================
Files 40 41 +1
Lines 2092 2096 +4
==========================================
+ Hits 1695 1699 +4
Misses 397 397 |
|
Thanks @whalebot-helmsman! |
|
Thank you for this @whalebot-helmsman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add commands to install wapiti binary on travis and run test for binary checking